Stop injecting NoWarns into repo's Directory.Build.props#17712
Merged
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom Nov 7, 2023
Merged
Stop injecting NoWarns into repo's Directory.Build.props#17712NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
Conversation
MichaelSimons
approved these changes
Nov 7, 2023
mthalman
approved these changes
Nov 7, 2023
Member
Author
|
Full validation build was successful - merging. |
Member
|
@NikolaMilosavljevic - This regressed the behavior for offline builds: dotnet/source-build#3729 |
Member
Author
That is odd. I've validated full set of VMR builds, although that was done for release/8.0.1xx: https://dev.azure.com/dnceng/internal/_build/results?buildId=2309593&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#3117
This PR stops modifications of
Directory.Build.propsto inject NoWarns during VMR build.I have validated that most of the NoWarns are not needed anymore. The only remaining one is in
nuget.clientfor which I'm adding a patch. Backport PR is also out: NuGet/NuGet.Client#5496Full validation build with updated
nuget.clientpatch is in progress: https://dev.azure.com/dnceng/internal/_build/results?buildId=2309593&view=results