Stop making tools.sh changes during source-build#17664
Merged
NikolaMilosavljevic merged 2 commits intodotnet:mainfrom Nov 1, 2023
Merged
Stop making tools.sh changes during source-build#17664NikolaMilosavljevic merged 2 commits intodotnet:mainfrom
NikolaMilosavljevic merged 2 commits intodotnet:mainfrom
Conversation
mthalman
approved these changes
Oct 31, 2023
src/SourceBuild/patches/xdt/0001-Allow-override-of-build-tool-framework-version.patch
Outdated
Show resolved
Hide resolved
…framework-version.patch Co-authored-by: Michael Simons <[email protected]>
MichaelSimons
approved these changes
Nov 1, 2023
Member
|
This is a bummer. The logic that was removed here would have been useful as part of the work I'm doing to get the stage 2 VMR build running. It requires the tooling to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#3171
We do not need to modify the return value anymore, as it does not impact source-build.
There are two patches for build tool framework changes - only two repos were affected.
command-line-apipatch references a backport PR: dotnet/command-line-api#2283.xdtpatch references the original issue, as backport is not deemed necessary.All changes were verified in private build and using internal VMR pipeline.