Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Updates #1609

Merged
merged 2 commits into from
Apr 19, 2019
Merged

CI Updates #1609

merged 2 commits into from
Apr 19, 2019

Conversation

dsplaisted
Copy link
Member

  • Include test results as part of build artifacts
  • Set test run title and build artifact filename to correspond to leg it came from
  • Add dependency on dotnet/sdk

@dsplaisted dsplaisted requested review from chcosta, a team and johnbeisner April 19, 2019 19:53
@chcosta chcosta mentioned this pull request Apr 19, 2019
Closed
chcosta
chcosta approved these changes Apr 19, 2019
View reviewed changes
eng/build.yml Outdated
enablePublishBuildAssets: true
enablePublishTestResults: true
enablePublishTestResults: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can also just remove these "enable" parameters so nobody feels the urge to switch them to true in a bad merge or something.

@dsplaisted dsplaisted merged commit 0b3ae80 into dotnet:master Apr 19, 2019
This was referenced May 10, 2019
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chcosta chcosta chcosta approved these changes

@johnbeisner johnbeisner Awaiting requested review from johnbeisner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsplaisted @chcosta