Skip to content

Correctly classify 'new', add plaintext, fix Namespace name #9910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TIHan merged 2 commits into from
Aug 14, 2020
Merged

Correctly classify 'new', add plaintext, fix Namespace name #9910

TIHan merged 2 commits into from
Aug 14, 2020

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Aug 10, 2020

Fixes #9561, pulled out from #9563

Also renames NameSpace to Namespace and adds a Plaintext classification type

@cartermp cartermp requested a review from TIHan August 10, 2020 22:55
@cartermp
Copy link
Contributor Author

cartermp commented Aug 10, 2020

cc @baronfel who requested the name change 🙂

@cartermp cartermp closed this Aug 13, 2020
@cartermp cartermp reopened this Aug 13, 2020
TIHan
TIHan approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TIHan TIHan merged commit c9fa54b into dotnet:master Aug 14, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@cartermp @nosami
Correctly classify 'new', add plaintext, fix Namespace name (dotnet#9910
671fe38 
)
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
@cartermp
Correctly classify 'new', add plaintext, fix Namespace name (dotnet#9910
9f20c97 
)
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
@cartermp @nosami
Correctly classify 'new', add plaintext, fix Namespace name (dotnet#9910
8d7578b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TIHan TIHan TIHan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'new' mistakenly classified as function or method, not keyword

2 participants

@cartermp @TIHan