Replaced old language service with Roslyn-based one #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </Vsix> | ||
| </Installation> | ||
| <Dependencies> | ||
| <Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.5,)" /> |
There was a problem hiding this comment.
Does 4.5 here mean anything? i.e. should it be 4.6?
Contributor
Author
There was a problem hiding this comment.
Changing to 4.6 to align to Roslyn's binaries
| let projectId = workspace.ProjectTracker.GetOrCreateProjectIdForPath(site.ProjectFileName(), site.ProjectFileName()) | ||
| if obj.ReferenceEquals(workspace.ProjectTracker.GetProject(projectId), null) then | ||
| let projectSite = new FSharpProjectSite(hier, this.SystemServiceProvider, workspace, site.ProjectFileName()); | ||
| projectSite.Initialize(hier, site) |
There was a problem hiding this comment.
Consider extracting a local for site.ProjectFileName().
|
|
||
| let references = this.GetReferences(site.CompilerFlags()) | ||
| // Added references | ||
| references |> |
Contributor
Author
There was a problem hiding this comment.
please check above comment
|
LGTM |
Contributor
Author
OmarTawfik
pushed a commit
that referenced
this pull request
Feb 19, 2016
Replaced old language service with Roslyn-based one
Contributor
|
This is such a great start - super to see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Microsoft/fsharp-compiler
This will stay in the new branch (roslyn), and users can try it by installing the vsix produced from the CI build there.
The current version just loads the new language service, and has no UI features (bare text editor).