Factor out CompilerAssert, TestFramework, ILChecker and Utilities #9350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice start. |
auduchinok
reviewed
Jun 1, 2020
brettfo
approved these changes
Jun 1, 2020
KevinRansom
approved these changes
Jun 1, 2020
TIHan
approved these changes
Jun 1, 2020
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
This looks good. Since we don't know what the name is yet, the current name is fine and can address it later.
Glad we are starting to separate this.
Contributor
|
@vzarytovskii , merge this when you ever want. |
| #endif | ||
|
|
||
| let inline getTestsDirectory dir = __SOURCE_DIRECTORY__ ++ dir | ||
| let testConfig' = getTestsDirectory >> testConfig |
Contributor
There was a problem hiding this comment.
I feel it would be better to hide the other testConfig rather than making a "prime":
- minimizes the changes
- the underlying
testConfigis not used anywhere
I stumbled on this change while rebasing a PR where I add a test in this file, it would have just worked using the F# feature of hidding symbols.
Member
Author
There was a problem hiding this comment.
It makes sense, will most likely be done as part of bigger tests refactoring.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…tnet#9350) * [WIP] Factor out CompilerAsserts, TestFramework, ILChecker to separate library * [WIP] +NUnit reference; Put Utilities.fs under module * Fixed tests to use new helpers library * Added <NoWarn>3186</NoWarn> to the FSharpSuite.Tests. * Added missing import for the TestHelpers. * Added missing solution entries for the project * Fix tests.fs to run tests with proper path * Fixed more paths in the tests * More fixes to test paths * More fixes to test paths (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the tests refactoring and restructuring initiaitive, created a new project with test helpers.
As a first step - moved CompilerAssert, TestFramework, ILChecker and Utilities there, so it will be easier to reuse in the future.
PS: Naming is hard, I've called it FSharp.TestHelpers for now, can be renamed if necessary.