Adjust FS-1075 : nullable interop - apply rule to all arguments, not just optional ones #9316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
force-pushed
the
feature/nullable-interop
branch
from
16eb5a5 to
6f0332d
Compare
cartermp
changed the title
KevinRansom
approved these changes
May 28, 2020
cartermp
approved these changes
May 29, 2020
KevinRansom
approved these changes
May 29, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…just optional ones (dotnet#9316) * adjust non-optional nullable interop * adjust non-optional nullable interop * fix error messages * fix baseline * fix baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential adjustment to RFC FS-1075 which is currently in preview
The adjustment is based on this usability feedback, which indicates that we should extend this to interoperating with non-optional nullable-typed arguments