-
Notifications
You must be signed in to change notification settings - Fork 842
Add char to types resolvable by GenericZero #8298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Needs a @dsyme review since I don't have context on this omission |
|
This is by design, though I don't feel strongly about it - the rationale is
Is there an example which shows the good reason to support Zero on Char? See also ConstraintSolver.fs, which would also need updating, and we would need testing of course. |
|
It's mostly for consistency. It is weird to have |
Can you add the fix to ConstraintSolver.fs too, and also add test cases? Thanks |
cartermp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Happypig375, I think this is a good change.
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution
|
@Happypig375 thank you for this contribution. Kevin |
* Add char to types resolvable by GenericZero * Add char to get_Zero solving * Add char to test * Add char to test * Add char to test again * Fix naming
It's resolvable by GenericOne already. Why not add it to GenericZero?