-
Notifications
You must be signed in to change notification settings - Fork 842
Fix inlining on subtypes #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Since the original bug was reported by me, I wouldn't mind checking the fix, but I'm not quite sure where to start. I'd assume I need a copy of this commit (easy enough), compile and then somehow use it to compile the projects / tests I have that showed exemplified this problem. My guess is the typical way to do this is by taking the compiled binaries and call fsc.exe directly? Or can I configure MSBuild to use another location for fsc? Sorry if this sounds basic, but I've been a consumer of F# until now, as opposed to being a contributor (other than reporting a handful of bugs). |
|
@abelbraaksma Take a look at the test cases here: https://github.com/Microsoft/visualfsharp/tree/master/tests/fsharpqa/Source/Optimizations/Inlining If you can add your test cases here then it will be in about the right place. Thank you for helping out Kevin |
|
According to @mpetruska, this PR also fixes #614, next to #740, as he mentions in that issue. |
|
@dsyme Is this PR ready to pull? |
|
Yes, it's ready |
|
Thanks for this contribution |
This fixes bug #740
As can be seen from the implementation, the restriction checking for lambdas with an implicit "base" variable (which allows base calls) were too strong - if the base variable is not used then the lambda can be propagated, which allows the inline keyword to be respected.
Suggestions for further testing welcome.