Remove IVTs to legacy language service#7001
Merged
KevinRansom merged 5 commits intodotnet:masterfrom Jun 19, 2019
cartermp:no-ivts-legacy-langservice
Merged
Remove IVTs to legacy language service#7001KevinRansom merged 5 commits intodotnet:masterfrom cartermp:no-ivts-legacy-langservice
KevinRansom merged 5 commits intodotnet:masterfrom
cartermp:no-ivts-legacy-langservice
Conversation
Contributor
Author
|
I have no clue what the ever loving hell this test does and why but it's failing: |
KevinRansom
approved these changes
Jun 15, 2019
Contributor
Author
|
I modified the code to use the public API for the information it needs and removed the test in question. I can't for the life of me understand the value in that test. |
Contributor
|
@cartermp Well, the tests are a sort of cheap evaluation of whether public types have been added or removed from those assemblies. If public types are removed its potentially a breaking change, if they are added it's potentially an unintentional increase in surface are. But that test does the job in a pretty bad way. And probably adds little value. |
Contributor
Author
|
Yeah, in this case I don't think they're of value here because the primary things they're testing are now dead code paths anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the dead code paths to no longer be IVT into FSharp.Compiler.Private.