Roslyn Shim - Round 2#6734
Merged
brettfo merged 23 commits intodotnet:release/dev16.2from Jun 13, 2019
Merged
Conversation
forki
reviewed
May 15, 2019
TIHan
commented
May 26, 2019
Contributor
Author
|
This is 99% done. Do not merge this in until Roslyn has merged theirs first. Still having some trouble getting DocumentDiagnosticAnalyzers to kick off. Once those are working and I do some testing, this will be 100% ready. |
Contributor
Author
|
Waiting for Roslyn's preview 4 branch. As soon as they have it, we update the package one more time. When Roslyn is ready to do an insertion, we merge and update the insertion with our bits. |
brettfo
approved these changes
Jun 13, 2019
Member
|
I spoke with @333fred and he pointed me to the Roslyn insertion into VS. I've updated |
Member
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Added shims over document diagnostic analyzers * Shims over completions and sig help * Removed content type definitions, putting them in external access * Added shim over InlineRenameService * We are now simply using export on the diagnostic analyzers * Using shim for document highlights service * GoToDefinition implemented with shims * NavigableSymbolsService shimmed * GoToDefinitionService shimmed * NavigationBarItemService shimmmed * Shimmed NavigateToSearchService * Quick cast fix * Using FSharpGlyphTags * Removed CommentSelectionService as it is ExternalAccess now * Shimmed BlockStructureService * Trying to finish shim * Removed folder from FSharp.Editor * Update package * fixing build * Trying to fix build * match roslyn package version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming the shim built in Roslyn, here -> dotnet/roslyn#35591 . That PR will actually remove most IVTs.
Still work in progress but want to make a PR to show the progress.