convert FCS MSBuild references to a NuGet package#6439
convert FCS MSBuild references to a NuGet package#6439KevinRansom merged 1 commit intodotnet:masterfrom brettfo:fcs-msbuild-nuget
Conversation
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Sweet, It's good to remove these binaries from our repo.
|
@baronfel Note this one Also I'm pretty sure this whole v12 DLL can be well and truly nuked from FCS. |
|
@dsyme do you mean during the integration that we move this reference to paket dependencies? Or that we can remove the creation of the FSharp.Compiler.Service.MSBuild.v12 component entirely? |
Ideally we should remove this DLL entirely. Also the ProjectCracker DLL, which deals with legacy project formats. I need to understand of Ionide depends on this in any way |
|
Ionide does depend on it for non-SDK style projects |
DO you know if it depends on FSharp.Compiler.Service.MSBuild.v12? There is the "SimulatedMSBuildReferenceResolver" which is normally an adequate replacement |
|
It would be great to have the same code used in assembly resolution for scripts in VS and other tools. If we're to use the simulated resolve everywhere it'd be great to update the VS integration too. |
As far as I remember FCS ProjectCracker depends on it for cracking any projects with ToolsVersion < 14.0. The good news is:
|
7 participants
An internal audit found some binaries that shouldn't be in this repo that need to be retrieved externally. One probable group are the MSBuild 12 binaries used under
fcs/.PR marked as draft until we get the final word on if the
Microsoft.Build.*.dllbinaries need to be removed.Other PRs to follow for other offending binaries.