Reduce allocations by favoring TryGetValue over TryFind#5715
Merged
KevinRansom merged 8 commits intodotnet:masterfrom Oct 2, 2018
Merged
Reduce allocations by favoring TryGetValue over TryFind#5715KevinRansom merged 8 commits intodotnet:masterfrom
KevinRansom merged 8 commits intodotnet:masterfrom
Conversation
forki
changed the title
forki
changed the title
Contributor
Author
|
@KevinRansom @cartermp the build error seems unrelated. Something wrong? |
Contributor
|
@forki I'm just going over the weekends PR's right now. I will get back to you. |
Contributor
|
I think they may be related: open namespaces or file ordering perhaps? |
# Conflicts: # src/fsharp/NameResolution.fs
Contributor
Author
|
ok let me check |
Contributor
Author
|
@KevinRansom it looks like FCS is using outdated fsharp.core. |
Contributor
Contributor
|
Can we get some perf numbers on this change? |
Contributor
|
I imagine the perf improvements are going to be negligable. My intuition is that there will be indeed be fewer allocations, but not nearly enough to notice. It is however a decent enough refactoring, I am fairly confident that if TryGetValue had existed when the code was originaly written, it would have been written this way. My sole concern, is having to push fcs up to FSharp.Core 4.5. Kevin |
Contributor
Author
|
I don't expect this to be measurable. These little Options are easy to
collect. It's just that we open up more and more and more of these
refactors and one day type checker is again 10 percent faster than last
release. Like we did over last year.
Kevin Ransom (msft) <[email protected]> schrieb am Mo., 1. Okt.
2018, 21:36:
… I imagine the perf improvements are going to be negligable. My intuition
is that there will be indeed be fewer allocations, but not nearly enough to
notice.
It is however a decent enough refactoring, I am fairly confident that if
TryGetValue had existed when the code was originaly written, it would have
been written this way. My sole concern, is having to push fcs up to
FSharp.Core 4.5.
Kevin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5715 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNGgz8FdivcoT7lZP0J4wD0O68JP0ks5ugm7MgaJpZM4XBnXn>
.
|
Contributor
|
Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.