Fix 996 - resource usage of infinite sequence expression containing "let rec" #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecursive function definitions
KevinRansom
approved these changes
Sep 1, 2017
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
This looks good to me.
dsyme
pushed a commit
to dsyme/fsharp
that referenced
this pull request
Oct 13, 2017
Merged
dsyme
pushed a commit
to dsyme/fsharp
that referenced
this pull request
Oct 13, 2017
KevinRansom
pushed a commit
that referenced
this pull request
Oct 13, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #996 by adding a "let rec" case to the compilation of sequence expressions to state machines
As noted in #996, compiling to these sequence expressions to state machines ensures that even infinite "tailcalling" sequences can execute with finite resources
From the user perspective this means that the introduction of an innocuous "let rec" doesn't change observed resource usage
As noted in the tests, this doesn't cover the case where a
let recis used to define a non-function value such as a memoization table.