Skip to content

CompileOps.qnameOrder uses full file path without extension to compare instead of module name inferred from file name #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vasily-kirichenko wants to merge 2 commits into from
Closed

CompileOps.qnameOrder uses full file path without extension to compare instead of module name inferred from file name #2686

vasily-kirichenko wants to merge 2 commits into from

Conversation

@vasily-kirichenko
Copy link
Contributor

@vasily-kirichenko vasily-kirichenko commented Mar 23, 2017

I fixes #2679

@dsyme I'm not sure I've not broken something. It should still work for sig + impl pairs because I compare by full file name without signature.

CompileOps.qnameOrder uses full file path without extension to compar…
9b76968 
…e instead of module name inferred from file name
@dsyme
Copy link
Contributor

dsyme commented Mar 23, 2017

It looks OK though I haven't looked at the CI failure

@vasily-kirichenko
Copy link
Contributor Author

vasily-kirichenko commented Mar 23, 2017

@dsyme I've looked :) Some of the failures

Errors and Failures

1) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.diamondAssembly
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args '-r:System.Core.dll --nowarn:20  --define:INTERACTIVE --maxerrors:1 --abortonerror test3.fsx' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\diamondAssembly'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at [email protected](String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 447
at FSharp.Test.FSharpSuite.TypeProviderTests.diamondAssembly() in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 63

2) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.helloWorld fsi
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args ' ' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\helloWorld'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 434
at [email protected](String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 454
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 103
at FSharp.Test.FSharpSuite.TypeProviderTests.helloWorld(Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 101

3) Failed : FSharp.Test.FSharpSuite.TypeProviderTests.wedgeAssembly
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsc.exe' with args '-r:System.Core.dll --nowarn:20 --define:COMPILED --debug+ -r:provider.dll --optimize- -o:test2a-with-sig-restricted.dll -a test2a-restricted.fsi test2a.fs' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\typeProviders\wedgeAssembly'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at [email protected](String flags, FSharpList`1 srcFiles) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 436
at FSharp.Test.FSharpSuite.TypeProviderTests.wedgeAssembly() in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\TypeProviderTests.fs:line 291

4) Failed : FSharp-Tests-Core+CoreTests.attributes-FSI_BASIC
Error running command 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\..\..\release\net40\bin\fsi.exe' with args '-r:System.Core.dll --nowarn:20  --define:INTERACTIVE --maxerrors:1 --abortonerror testlib.fsi testlib.fs test.fsx' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\core\attributes'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 249
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 428
at [email protected](String flags, FSharpList`1 sources) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 447
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 95
at SingleTest.singleTestBuildAndRun(String dir, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 172

No idea how it's related. I re-run the build, same failures.

@vasily-kirichenko
Copy link
Contributor Author

vasily-kirichenko commented Mar 27, 2017

I have no interest to finish it, sorry.

This was referenced Mar 29, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Same file name across different folders fails the compilation with error FS0239

3 participants

@vasily-kirichenko @dsyme @msftclas