Skip to content

Surface area test output improvements #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinRansom merged 1 commit into from
Feb 16, 2017
Merged

Surface area test output improvements #2445

KevinRansom merged 1 commit into from
Feb 16, 2017

Conversation

@jack-pappas
Copy link
Contributor

@jack-pappas jack-pappas commented Feb 16, 2017

Re-implemented the way the test which compares actual vs. expected surface area works, so that when they don't match exactly, the output only displays the members which don't match. The new output message also shows which members were "unexpectedly present" and "unexpectedly missing", which makes it easier to diagnose the cause of the test failure.

@jack-pappas
Surface area test output improvements.
168df7a 
Re-implemented the way the test which compares actual vs. expected
surface area works, so that when they don't match exactly, the output
only displays the members which don't match. The new output message
also shows which members were "unexpectedly present" and
"unexpectedly missing", which makes it easier to diagnose the cause
of the test failure.
@jack-pappas jack-pappas mentioned this pull request Feb 16, 2017
Merged
19 tasks
KevinRansom
KevinRansom approved these changes Feb 16, 2017
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot ... I love this.

@KevinRansom
Copy link
Contributor

KevinRansom commented Feb 16, 2017

Check out an intentional difference in the surface area caught by this test:

Errors and Failures

1) Failed : FSharp.Core.Unittests.SurfaceArea.SurfaceAreaTest.VerifyArea
Assembly: FSharp.Core, Version=4.4.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
Expected and actual surface area don't match. To see the delta, run:
    windiff c:\microsoft\visualfsharp\src\fsharp\FSharp.Core.Unittests\SurfaceArea.net40.fs c:\microsoft\visualfsharp\release\net40\bin\CoreUnit_net40_Xml.xml

Unexpectedly missing (expected, not actual):
    Microsoft.FSharp.Collections.ArrayModule: T[] Replicate[T](Int32, T)

Unexpectedly present (actual, not expected):
    Microsoft.FSharp.Collections.ArrayModule: T[] Replucate[T](Int32, T)
at FSharp.Core.Unittests.LibraryTestFx.SurfaceArea.verify(String expected, String platform, String fileName) in c:\microsoft\visualfsharp\src\fsharp\FSharp.Core.Unittests\LibraryTestFx.fs:line 176

@KevinRansom KevinRansom merged commit 1a5b23d into dotnet:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jack-pappas @KevinRansom @msftclas