Fix word-splitting bug in before_install.sh #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ok, it seems that while this change has fixed the bug on Mac OS X, it's broken that same line of the script on Ubuntu. I'll try to fix this so it works on both systems. |
Also, the certificate check (via certmgr) needs to check both the user and machine stores to ensure it works on a variety of systems. Related to dotnet#2125.
jack-pappas
force-pushed
the
fix-mac-builds-04
branch
from
b61b7fe to
03274f1
Compare
Contributor
Author
|
Figured it out -- when installing mono on Ubuntu (at least through apt-get), the X.509 certificates are installed into the machine-level store; on OS X / macOS they're installed to the user store. |
KevinRansom
approved these changes
Feb 16, 2017
Contributor
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug related to word-splitting in
before_install.shwhich was introduced in cc33ee4 and affects at least bash on Mac OS X. I've fixed the script so it's quoted to avoid word-splitting while still adhering to POSIX shell language (thanks shellcheck!).Related to issue #2125.