Speed up checkPathForIllegalChars without a cache. #2138
Merged
+5
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timing for 100k checks of the path "c:\dev\myproject\utilities\longstring with spaces\filename.fs": Original ~250ms This method ~100ms
Contributor
|
Out of curiosity -- would you mind benchmarking the original function again, but modifying it to iterate over |
Contributor
Author
|
Thanks for the suggestion. I tried it, and it didn't help. The improvement comes from HashSet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timing for 100k checks of the path "c:\dev\myproject\utilities\longstring with spaces\filename.fs":
Original ~250ms
This function ~100ms
I don't expect this to be noticeable in the compiler but it might be in IDEs.
Uses a mutable HashSet but doesn't let it escape the function.