Replace pattern matches inside async blocks with AsyncMaybe CE #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasily-kirichenko
changed the title
vasily-kirichenko
changed the title
vasily-kirichenko
changed the title
KevinRansom
approved these changes
Dec 31, 2016
Contributor
|
@vasily-kirichenko conflicts mate. |
# Conflicts: # vsintegration/src/FSharp.Editor/CodeFix/AddOpenCodeFixProvider.fs # vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs
Contributor
|
@dotnet-bot test this please |
Contributor
|
I'm guessing this is at the heart of where you work. More conflicts. |
# Conflicts: # vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs # vsintegration/src/FSharp.Editor/Navigation/FindReferencesService.fs
Contributor
Author
|
@KevinRansom fixed. |
Contributor
|
Awesome! Great to have this in. Definitely makes a lot of things look nicer, since the "asynchronous operation that returns an option" is so common in this project. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…t#2136) * use asyncMaybe everywhere * fix compilation * continue the refactoring * finish the refactoring * fixed: AsyncMaybe.Delay was not lazy * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of boilerplate.