Skip to content

Conversation

@jack-pappas
Copy link
Contributor

This change adds OSX to the list of operating systems to run Jenkins CI builds on.

@KevinRansom KevinRansom merged commit c505000 into dotnet:master Dec 31, 2016
@jack-pappas jack-pappas deleted the fix-mac-builds-02 branch December 31, 2016 05:48
KevinRansom added a commit that referenced this pull request Dec 31, 2016
@KevinRansom
Copy link
Contributor

@jack-pappas I reverted this for now. The OSX jenkins task fails.

@dsyme
Copy link
Contributor

dsyme commented Dec 31, 2016

Sample Log from https://ci2.dot.net/job/Microsoft_visualfsharp/job/master/job/release_osx_prtest/7/

00:28:42 ./before_install.sh: line 31: certmgr -list -c Trust | grep -c -F "X.509": command not found
00:28:42 ./before_install.sh: line 31: [: -le: unary operator expected
00:28:42 ./before_install.sh: line 38: mono: command not found
00:28:42 chmod: packages/FSharp.Compiler.Tools.4.0.1.19/tools/fsi.exe: No such file or directory
00:28:42 chmod: packages/FsLexYacc.7.0.3/build/fslex.exe: No such file or directory
00:28:42 chmod: packages/FsLexYacc.7.0.3/build/fsyacc.exe: No such file or directory
00:28:42 ./build.sh: line 16: xbuild: command not found
00:28:42 ./build.sh: line 17: xbuild: command not found

@jack-pappas
Copy link
Contributor Author

Looks like mono isn't installed on the OSX images? I can add a download/install step to the build script to handle that.

I don't see an existing build step to install mono on the Ubuntu14.04 VM we're already using in CI builds -- is Mono already installed on that image?

@jack-pappas
Copy link
Contributor Author

Is there any way I can get a list of what's pre-installed on the Jenkins OS X images? It'll be easy enough to add a bit of extra code to before_install.sh to install prerequisites on OSX, but it'll be significantly easier/faster if I don't have to guess what's already on the image.

cc @cartermp

@cartermp
Copy link
Contributor

I don't know how to get that information. @KevinRansom?

@jack-pappas
Copy link
Contributor Author

Maybe @mmitche knows what's installed on the OSX images, or knows how to find out?

@mmitche
Copy link
Member

mmitche commented Feb 13, 2017

I don't remember offhand what we have installed (this is an area we need to improve). It was primarily driven by corefx's requirements. What do you need?

@jack-pappas
Copy link
Contributor Author

I think we need mono installed on these images (the most recent stable build would be best). If possible, it would be nice to also have homebrew available so we can have our build script install necessary dependencies.

@mmitche
Copy link
Member

mmitche commented Feb 14, 2017

@jack-pappas Should already be there. I think 4.6.2 mono is installed.

@jack-pappas jack-pappas restored the fix-mac-builds-02 branch February 15, 2017 00:16
@jack-pappas jack-pappas deleted the fix-mac-builds-02 branch February 15, 2017 00:19
@jack-pappas
Copy link
Contributor Author

Was mono added to the images recently? When we enabled OSX builds for this repo, we got failures due to missing mono and certmgr (a tool that ships with mono) commands -- see Don's comment above.

@jack-pappas
Copy link
Contributor Author

Turns out there's also a word-splitting bug I introduced in the script (which affects the certmgr call on line 31). I'll fix that and see if it fixes our issues here.

@mmitche
Copy link
Member

mmitche commented Feb 15, 2017

@jack-pappas Maybe a month or two?

@jack-pappas
Copy link
Contributor Author

@mmitche It's possible the last time we tried to run this build was before then. In any case, now that we know mono is installed on the macOS images, we can try to get this build working again (I've fixed the broken script and submitted a PR for it).

Is there any way to enable the "OSX" build again, but do it in such a way that any build failures are ignored for the purposes of determining whether some PR (or the master branch) is "passing"? The mac builds definitely still aren't working for this repository, but it'll be quicker to fix things if everyone can see the compilation errors (so we can work together to fix them).

@mmitche
Copy link
Member

mmitche commented Feb 16, 2017

Yeah, in your test script, you'd detect the OS you're trying to test as OSX or whatnot, and simply return 0 so as not to fail the command

@jack-pappas
Copy link
Contributor Author

@KevinRansom Would you mind reverting your change (to re-enable my change to add OS X to the Jenkins builds)? I'm able to build master fine now on my Mac, likely due to the changes Don merged in #2442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants