-
Notifications
You must be signed in to change notification settings - Fork 842
Add OSX to OS list for Jenkins CI builds #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c505000.
|
@jack-pappas I reverted this for now. The OSX jenkins task fails. |
|
|
Looks like mono isn't installed on the OSX images? I can add a download/install step to the build script to handle that. I don't see an existing build step to install mono on the |
|
Is there any way I can get a list of what's pre-installed on the Jenkins OS X images? It'll be easy enough to add a bit of extra code to cc @cartermp |
|
I don't know how to get that information. @KevinRansom? |
|
Maybe @mmitche knows what's installed on the OSX images, or knows how to find out? |
|
I don't remember offhand what we have installed (this is an area we need to improve). It was primarily driven by corefx's requirements. What do you need? |
|
I think we need mono installed on these images (the most recent stable build would be best). If possible, it would be nice to also have homebrew available so we can have our build script install necessary dependencies. |
|
@jack-pappas Should already be there. I think 4.6.2 mono is installed. |
|
Was mono added to the images recently? When we enabled OSX builds for this repo, we got failures due to missing |
|
Turns out there's also a word-splitting bug I introduced in the script (which affects the certmgr call on line 31). I'll fix that and see if it fixes our issues here. |
|
@jack-pappas Maybe a month or two? |
|
@mmitche It's possible the last time we tried to run this build was before then. In any case, now that we know mono is installed on the macOS images, we can try to get this build working again (I've fixed the broken script and submitted a PR for it). Is there any way to enable the "OSX" build again, but do it in such a way that any build failures are ignored for the purposes of determining whether some PR (or the |
|
Yeah, in your test script, you'd detect the OS you're trying to test as OSX or whatnot, and simply return 0 so as not to fail the command |
|
@KevinRansom Would you mind reverting your change (to re-enable my change to add OS X to the Jenkins builds)? I'm able to build |
This change adds OSX to the list of operating systems to run Jenkins CI builds on.