Modify before_install.sh for OSX compatibility #2125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify before_install.sh so it works on OSX. The script now performs rudimentary OS detection, and Linux-specific commands are only executed when running on Linux.
jack-pappas
force-pushed
the
fix-mac-builds
branch
from
a2db16f to
467b79e
Compare
Use the correct string comparison operator (= instead of ==). Modified the command substitution where certmgr is called so it uses the modern $(...) syntax instead of backticks.
KevinRansom
approved these changes
Dec 29, 2016
Contributor
|
Thanks for this. |
7 tasks
Contributor
|
Thank you for taking care of this Kevin |
jack-pappas
added a commit
to jack-pappas/visualfsharp
that referenced
this pull request
Feb 16, 2017
Also, the certificate check (via certmgr) needs to check both the user and machine stores to ensure it works on a variety of systems. Related to dotnet#2125.
KevinRansom
pushed a commit
that referenced
this pull request
Feb 16, 2017
Also, the certificate check (via certmgr) needs to check both the user and machine stores to ensure it works on a variety of systems. Related to #2125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify before_install.sh so it works on OSX. The script now performs rudimentary OS detection, and Linux-specific commands are only executed when running on Linux.
Related to #2114.