Implement XmlDoc comment generation #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It seems it sometimes does not work:
|
Contributor
Author
|
@vasily-kirichenko I pushed a fix. |
KevinRansom
approved these changes
Dec 29, 2016
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
This looks great, although it reminds me, that we may want to ensure that we use coreclr based references rather than desktop ones to ensure portability.
Contributor
|
@KevinRansom What are you referring to with "references", the |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Add a service for XmlDocParser * Add corresponding VS service * Use VS workspace to retrieve correct documents * Use current snapshot to ensure source text is fresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2078.
As discussed in #2078, there is no easy way to do this via Roslyn. So we use normal VS service and use Roslyn workspaces to manage documents only.
It still works the same way as described at http://fsprojects.github.io/VisualFSharpPowerTools/xmldoc.html