Skip to content

Conversation

@dungpa
Copy link
Contributor

@dungpa dungpa commented Dec 28, 2016

@vasily-kirichenko
Copy link
Contributor

vasily-kirichenko commented Dec 29, 2016

@dungpa works OK to me. What about removing "explicitly" word from the title? In F# you cannot implement an interface implicitly, so this word is just noise.

@dungpa
Copy link
Contributor Author

dungpa commented Dec 29, 2016

The word 'explicitly' is there so that people coming from C# know exactly what to expect (C# editor provides 'Implement interface' and 'Implement interface explicitly' as two choices).

I can remove it if anyone else also thinks it's redundant?

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinRansom KevinRansom merged commit b5bf291 into dotnet:master Dec 29, 2016
@dungpa dungpa deleted the implement-interface branch December 29, 2016 17:02
@cartermp
Copy link
Contributor

I think we can remove the "explicitly" text since there is no implicit interface implementation in F# as @vasily-kirichenko mentioned. I think that having it there may confuse C# people, who may expect the ability to "just" implement an interface and wonder why they "have" to do it explicitly, and for people with no C# experience there's no issue in implicit v. explicit terminology.

@dungpa
Copy link
Contributor Author

dungpa commented Dec 29, 2016

@vasily-kirichenko @cartermp Here it is #2126

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
* Insert closing brackets if they are missing

* Find correct interface identifiers if object expressions are on the same lines with let bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants