-
Notifications
You must be signed in to change notification settings - Fork 842
Suggest Record labels and Union cases #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I this "Replace with" suffix is not needed. What about |
|
How is C# doing this? The text is from earlier commit. But we can change it. |
|
ready for review |
|
Hmmm. Not sure I like surfacing the possibility of something completely unrelated, like |
|
The GetHashCode can probably be filtered out here since it's not a static method. But this is unrelated to this PR here since without this PR it would only propose the GetHashCode (which is actually worse) |
|
Okay. I think if we can filter out non-static members on types then all the suggestions will seem relevant. |
|
just took a quick look. this is not easy to determine at this location since we don't know if we are invoked in static or member position. So since this PR only improves the current situation it should still be merged. I have an idea for the filtering and will apply that later. |
|
Sounds good. |
|
Ok all tests fixed |
|
@cartermp since I saw your list on twitter. This pr is not for the analyzer. It's actually just the error message improvement. |
|
Good to know! |
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Uh oh!
There was an error while loading. Please reload this page.