Propose Uppercase for FS0053 #2116
Conversation
forki
commented
Dec 27, 2016
forki
commented
|
I'm pretty sure you should start an Inline Rename session for this fix, because without it you do not change all the DU case occurences:
However, this code is not from a Code Fix, maybe we should find all symbol references on our own and "change" all documents where it's used to get nice multi-file preview. Or maybe not. Could you look for a Code Fix that changes multiple documents in the Roslyn sources? Looks like we should use this overload, which expect us to return the whole new
|
|
Mhm not sure if can do this right now. If you think you see a solution then could you please try it? You have much more experience with the VFPT features. |
|
@forki I've send a PR, looks like this:
|
Make ProposeUppercaseLabel code fix work on all symbol uses
|
That's awesome |
|
As discussed in different channel: @vasily-kirichenko will extract the "find references" logic soon since we believe this will be used in many code fixes. |
Conflicts: vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs
|
ready for review. |
Extract `changeAllSymbolReferences` function
|
thanks @vasily-kirichenko for refactoring. @KevinRansom this is ready |
|
appveyor fail is unrelated |
* Propose Uppercase for FS0053 * make ProposeUppercaseLabel code fix work on all symbol uses * cleanup * refactor with asyncMaybe * add ParseAndCheckDocument * refactor ProposeUppercaseLabel
4 participants
