Remove trailing semicolon analyzer & code fix and Refactor lexer logic in helpers into a MEF class #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This one should be run against the compiler itself ;-) |
cartermp
changed the title
Contributor
|
Renamed the PR to reflect that this PR is two things:
|
Contributor
Author
|
@dotnet-bot test this please |
…haracter is the semicolon
…tead of ToString + GetHashCode for text line unique key eliminate a seq and an array allocation in ColorizationService
# Conflicts: # vsintegration/src/FSharp.Editor/Classification/ColorizationService.fs # vsintegration/src/FSharp.Editor/InlineRename/InlineRenameService.fs # vsintegration/src/FSharp.Editor/QuickInfo/QuickInfoProvider.fs
Contributor
|
@vasily-kirichenko conflicts + ton of errors Kevin |
…icolon # Conflicts: # vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs # vsintegration/src/FSharp.Editor/srFSharp.Editor.fs
Contributor
Author
|
@KevinRansom done |
Contributor
Author
|
It's ready. |
Contributor
|
@vasily-kirichenko |
…icolon # Conflicts: # vsintegration/src/FSharp.Editor/CodeFixes/ImplementInterfaceCodeFixProvider.fs # vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs
Contributor
Author
|
Fixed. |
Contributor
|
@vasily-kirichenko |
…icolon # Conflicts: # vsintegration/src/FSharp.Editor/CodeFixes/AddOpen.fs # vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
Contributor
Author
|
Fixed. I experience this behavior on this PR:
I'm not sure if it's the same on master, will check. |
Contributor
Author
|
Everything is ok in master. I'll remove the code fix, it seems it makes more harm than usefulness. |
Contributor
Author
|
Oookey, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;tokenFSharpTokenizerLexState * Location>, if aFSharpTokenizerLexStatehas changed since last time, ask the lexer cache forall tokens * FSharpTokenizerLexStateand update our cache