Reduce IL generation in GetHashCode for Discriminated Unions #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liboz
changed the title
liboz
changed the title
Contributor
Author
|
Okay this is ready for review. I had to add a boolean in the Optimizer to ensure that GetHashCode is not inlined even if it would have been possible to optimize it. This is because otherwise the |
KevinRansom
approved these changes
Dec 28, 2016
dsyme
reviewed
Dec 28, 2016
| (mkCombineHashGenerators g m (List.mapi (mkHash ucve) ucase1.RecdFields) (mkLocalValRef accv) acce)) | ||
| Some(mkCase(Test.UnionCase(c1ref,tinst),mbuilder.AddResultTarget(test,SuppressSequencePointAtTarget))) | ||
|
|
||
| let nullary,nonNullary = ucases |
Contributor
There was a problem hiding this comment.
Normally please use formatting
let x,y =
abc def
rather than
let x,y = abc
def
Contributor
Author
There was a problem hiding this comment.
Thanks. I'll try to remember to do so in the future. One quick clarification though: I assume it's alright if there are enough pipes in a row to put pipes on their own lines?
Also, do you want me to fix it in this PR?
Contributor
|
Approved once tests are green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #1366