Better attribute completion #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to handle attributes in a special way at attribute application point (wip)
Contributor
|
Now this is nice. |
vladima
reviewed
Dec 23, 2016
src/fsharp/vs/ServiceDeclarations.fs
Outdated
| | [] -> failwith "Unexpected empty bag" | ||
| | items -> | ||
| let glyphMajor, glyphMinor = GlyphOfItem(denv,items.Head) | ||
| let nm = if atAttributeApplication && IsAttribute infoReader items.Head then nm.[0..nm.Length-10] else nm |
Contributor
There was a problem hiding this comment.
nit: can you add a comment?
Contributor
|
Looks great! |
Contributor
|
Thanks for doing this so quickly - fantastic 👍 |
Contributor
Author
|
@dotnet-bot test this please |
Contributor
|
Great stuff. |
Contributor
|
Yes, this is great |
Contributor
|
some autocomplete test failures may be related: |
…does not have it fix related tests
…e application position
Contributor
Author
|
Different attribute completiion tests fails from launch to launch. I think it's because completion list caching:
This behavior is also reproduced in the editor. We should clean the cache if we move from attr appl point to non such a point. |
Contributor
Author
|
Where can I find why the tests failed? I examined all the files in this list:
and found nothing labeled as "error" or "failure". |
Contributor
|
You need to click into the left menu to "console output". Then scroll down
to the bottom and read from bottom to top.
Am 28.12.2016 18:12 schrieb "Vasily Kirichenko" <[email protected]>:
… Where can I find why the tests failed? I examined all the files in this
list:
[image: image]
<https://cloud.githubusercontent.com/assets/873919/21527110/eee782ee-cd39-11e6-864c-c2b9e76856d8.png>
and found nothing labeled as "error" or "failure".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2095 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNFmkQSQ1-xR6jMdg4xbsr-lJWMFJks5rMpiUgaJpZM4LVDKk>
.
|
Contributor
Author
|
@forki Thanks, but I didn't find any failures in the console output, the only thing that has helped is searching for "failure" in the text that's available by "View as plain text" link. |
Contributor
Author
|
Hm. I've no idea why the tests do not pass now. The sample from one of them works in editor:
|
Contributor
Author
|
@dotnet-bot test this please |
Contributor
|
Still a couple of failures: |
…mpletion # Conflicts: # vsintegration/src/FSharp.Editor/Common/LanguageService.fs
Contributor
Author
|
I think it's finally ready. |
Contributor
|
Thanks for taking care of this. Kevin |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* add FSharpDeclarationListItem.IsAttribute try to handle attributes in a special way at attribute application point (wip) * almost works * suggest all types, modules and namespaces at attribute application position * fix Context.AttributeApplication detection * autocomplete does not remove "Attribute" suffix if an attribute type does not have it fix related tests * do not try to use AstVisitorBase to determine that we are at attribute application position * try to fix tests * fix some tests * cut attribute prefix on editor side * fixed: IsAttribute can throw exceptions which results with empty completion list * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #2041
At attribute application position: