-
Notifications
You must be signed in to change notification settings - Fork 842
Use Roslyn line numbers only in lexer cache #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dotnet-bot test this please |
|
@vasily-kirichenko I think these may be related to the change. |
|
Fixed. |
|
CI error is unrelated. Please merge asap |
|
@vasily-kirichenko, would you resolve the conflicts please. Kevin |
|
this code was merged to #2102 and further refactored to Lexer class, so merging this PR would create conflicts and it's needed anymore anyway. |
|
So the crash on last line is gone?
Am 28.12.2016 1:55 nachm. schrieb "Vasily Kirichenko" <
[email protected]>:
… Closed #2090 <#2090>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2090 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNH772k9egd_cllupjJohAjFoxFytks5rMlw8gaJpZM4LUvQz>
.
|
|
@forki Yes. |
# Conflicts: # vsintegration/src/FSharp.Editor/Common/CommonHelpers.fs
|
I'm reopening this as I closed #2102, which included "out of range" bug fix merged from this PR. |
* revert "Use Roslyn line numbers only in lexer cache" #2090 * fix OutOfRangeException in getCachedSourceLineData * fixed: lexer cache does not work at all * fix finding start line for relexing in getCachedSourceLineData
* use Roslyn line numbers only in lexer cache * fix and refactor getSymbolAtPosition * fix after merge * fix out of range exn
* revert "Use Roslyn line numbers only in lexer cache" dotnet#2090 * fix OutOfRangeException in getCachedSourceLineData * fixed: lexer cache does not work at all * fix finding start line for relexing in getCachedSourceLineData
No description provided.