Parallel compilation of scripts#19649
Open
majocha wants to merge 5 commits intodotnet:mainfrom
Open
Conversation
Contributor
❗ Release notes required
|
2 tasks
Contributor
Author
|
So, the diamondAssembly test is the only failing one. Interestingly, the failure is not a new one, looking at git history: 90c4e66 |
Contributor
Author
|
The issue is caused by singling out |
majocha
force-pushed
the
parallelcompilation-fsx
branch
from
0803290 to
fb40499
Compare
majocha
commented
May 4, 2026
|
|
||
| allDependencies | ||
|
|
||
| // If there is a script in the project, we just process sequentially all the files that may have been added as part of the script closure. |
Contributor
Author
There was a problem hiding this comment.
this is the removed ugly workaround.
majocha
commented
May 4, 2026
| mkSingletonDict name { Current = current; Children = node } |> continuation) | ||
| tail | ||
|
|
||
| if kind = SynModuleOrNamespaceKind.AnonModule then |
Contributor
Author
There was a problem hiding this comment.
Does removing this special case break anything? Let's see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graph based type checking did not handle compilations that include script files.
Previous workaround was to simply sequentially check files up to the last script on the sources list.
The actual bug was that graph checking did not record modules implicitly provided by any script file in the compilation, in effect missing dependencies like :