fix syntax errors and transitive errors in scripts #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2016
Contributor
|
@dsyme Please don't Pull any PR's for a while. |
Contributor
|
@KevinRansom couldn't just use another branch for release preparation? This would not stop the time for others. |
Contributor
|
@forki we could have, and will next time around ... it's just that the insanity of the last few weeks meant we wanted to stay with what we had until too late to change. |
Contributor
|
From what I can see I have to say the last 2 or 3 weeks were awesome for
the project ;-)
|
Contributor
Author
|
@KevinRansom No problem.
|
Contributor
|
We will use rc3 for the next release and master. Brett has to generate the necessary VSO build goop ... and we will be golden. |
Contributor
|
@dotnet-bot test this please |
1 similar comment
Contributor
|
@dotnet-bot test this please |
Closed
Contributor
Author
|
@KevinRansom I'm bringing this PR up-to-date, thanks |
Contributor
|
@dotnet-bot test this please |
Contributor
|
Woot! Happy to see this merged. |
Contributor
Author
|
Super, thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of issues with error reporting in scripts
#loadon missing files are not shown in the IDE #1962The second was caused by recent F# 4.1 fixes to replay errors from the load closure computation. We need to be more selective about which errors we replay (do not replay parsing errors, which may not be valid for cached entries in the loadClosure cache).
We also had a bad cache key in script LoadClosure computation (we were not keying on the full set of
#loaddirectives which support the LoadClosure computation, and were not keying on unresolved assembly references)Some testing needs to be added, will look at that tomorrow
I added some cleanup for diagnostics processing in general, unifying the "Error" and "Warning" paths into single "Diagnostic" paths, passing the
isErrorparameter. Some paths were usingwarn==not isErrorand these are switched around to just useisError