use shared MEF components instead of static fields #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The CI is a bit borked right now and we are in the middle of an office move. Kevin |
Contributor
|
@KevinRansom I think it's kind of important to have that fixed right now. |
Contributor
|
Confused. What does office move have to do with CI server? |
Member
|
None of the people in redmond are allowed in the building, and many are in fact off work yesterday and today... |
Contributor
|
Still don't understand what this has to do with a CI server. ;-) |
Contributor
|
Self hosted in the corner of said office? ;) |
Contributor
|
@forki @isaacabraham I'm on it. |
Contributor
|
OK, well, this change looks good to me. Total MEF voodoo :) |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* use shared MEF components instead of static fields * revert back stateless static methods that were used in tests * remove Document from the signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.