Skip to content

Make init-tools.cmd use default proxy #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsyme merged 1 commit into from
Nov 30, 2016
Merged

Make init-tools.cmd use default proxy #1897

dsyme merged 1 commit into from
Nov 30, 2016

Conversation

@vasily-kirichenko
Copy link
Contributor

@vasily-kirichenko vasily-kirichenko commented Nov 30, 2016

add notes on configuring nuget.exe to use proxy

make init-tools.cmd use default proxy
f32b96b 
add notes on configuring nuget.exe to use proxy
@dsyme
Copy link
Contributor

dsyme commented Nov 30, 2016

These failures are my fauilt due to the glyph fix, I'm working on it


1) Error : Tests.LanguageService.AutoCompletion.UsingMSBuild.ListFunctions
System.Exception : Unexpected item empty seen with declaration type 138
   at Tests.LanguageService.AutoCompletion.UsingMSBuild.ListFunctions() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Completion.fs:line 4494

2) Error : Tests.LanguageService.AutoCompletion.UsingMSBuild.OfSeveralModuleMembers
System.Exception : Unexpected module member Constant seen with declaration type 138
   at Tests.LanguageService.AutoCompletion.UsingMSBuild.OfSeveralModuleMembers() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Completion.fs:line 4452

3) Error : Tests.LanguageService.AutoCompletion.UsingProjectSystem.ListFunctions
System.Exception : Unexpected item empty seen with declaration type 138
   at Tests.LanguageService.AutoCompletion.UsingMSBuild.ListFunctions() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Completion.fs:line 4494

4) Error : Tests.LanguageService.AutoCompletion.UsingProjectSystem.OfSeveralModuleMembers
System.Exception : Unexpected module member Constant seen with declaration type 138
   at Tests.LanguageService.AutoCompletion.UsingMSBuild.OfSeveralModuleMembers() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.LanguageService.Completion.fs:line 4452

dsyme
dsyme reviewed Nov 30, 2016
View reviewed changes
init-tools.cmd
if NOT exist "%PACKAGES_DIR%NuGet.exe" (
if NOT exist "%PACKAGES_DIR%" mkdir "%PACKAGES_DIR%"
powershell -NoProfile -ExecutionPolicy unrestricted -Command "(New-Object Net.WebClient).DownloadFile('https://www.nuget.org/nuget.exe', '%PACKAGES_DIR%NuGet.exe')
powershell -NoProfile -ExecutionPolicy unrestricted -Command "$wc = New-Object System.Net.WebClient; $wc.Proxy = [System.Net.WebRequest]::DefaultWebProxy; $wc.Proxy.Credentials = [System.Net.CredentialCache]::DefaultNetworkCredentials; $wc.DownloadFile('https://www.nuget.org/nuget.exe', '%PACKAGES_DIR%NuGet.exe')
Copy link
Contributor

@dsyme dsyme Nov 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from some dotnet project init-tools.cmd (corefx?), so it might be good to fold a fix back there too

@dsyme dsyme merged commit 64ce7c9 into dotnet:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vasily-kirichenko @dsyme @msftclas