Trace errors in from fsdiff #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
force-pushed
the
fsdiff
branch
3 times, most recently
from
2586e29 to
ac40cf8
Compare
Contributor
|
We should really just remove all calls to fsdiff (at least from FSHarpSuite) and use direct calls to the logic. THere's only pain in having this exe. I'm not sure if it's used by the FSharpQA suite too though |
Contributor
Author
|
Good point. Will try to do that. That code looks like it's in need of a big clean up anyways |
forki
force-pushed
the
fsdiff
branch
4 times, most recently
from
46dd05f to
53b8637
Compare
Contributor
Author
|
@enricosada could you please review this? thx |
Contributor
|
@forki seems ok 👍 |
Contributor
Author
|
@dsyme can we get this in? would help to understand errors in ci_part2 |
Contributor
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this to fix bugs that are not reproducible on my system.
I wonder if we can upload the .err file to jenkins instead of tracing it