Skip to content

Allow _ in use! bindings values#18487

Merged
T-Gro merged 17 commits intodotnet:mainfrom
edgarfgp:fix-16343
Apr 28, 2025
Merged

Allow _ in use! bindings values#18487
T-Gro merged 17 commits intodotnet:mainfrom
edgarfgp:fix-16343

Conversation

@edgarfgp
Copy link
Copy Markdown
Contributor

@edgarfgp edgarfgp commented Apr 20, 2025 •
edited
Loading

Description

Currently if we use any pattern that is not Named or LongIdent it errors miserably pointing at the use! range.

Also it does not allow to wrap patterns In parens(I don't see the point in restricting use e.g. (x), (__), (_).)

So in this PR:

  • Allows Named or LongIdent and Wild(only in preview) to be wrapped in parens
  • Updates the error range to use the pat range instead of the use! range

BEFORE

counterDisposable {
    use! res = new Disposable() // No Error
    use! __ = new Disposable() // No Error
    use! (res1) = new Disposable() // Error
    ^^^^
    use! (___) = new Disposable() // Error
    ^^^^
    use! _ = new Disposable() // Error
    ^^^^
    use! [| 1 |] = new Disposable() // Error
    ^^^^
    return ()
}

AFTER

counterDisposable {
    use! res = new Disposable() // No Error
    use! __ = new Disposable() // No Error
    use! (res1) = new Disposable() // No Error
    use! (___) = new Disposable() // No Error
    use! _ = new Disposable() // No Error
    
    use! [| 1 |] = new Disposable() // Error
         ^^^^^^^
    return ()
}

Fixes #16343

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp changed the title Allow _ in use! _ bindings values Allow _ in use! bindings values Apr 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md
LanguageFeatures.fsi docs/release-notes/.Language/preview.md

edgarfgp added 3 commits April 20, 2025 17:55
@edgarfgp
Allow _ in use! bindings values
43d6b78
@edgarfgp
Merge branch 'fix-16343' of github.com:edgarfgp/fsharp into fix-16343
f27a573 
# Conflicts:
#	docs/release-notes/.FSharp.Compiler.Service/9.0.300.md
#	docs/release-notes/.Language/preview.md
@edgarfgp
update tests
f7c9620
@edgarfgp edgarfgp force-pushed the fix-16343 branch 4 times, most recently from 44694b7 to 949ee66 Compare April 22, 2025 05:41
@edgarfgp edgarfgp marked this pull request as ready for review April 22, 2025 16:14
@edgarfgp edgarfgp requested a review from a team as a code owner April 22, 2025 16:14
@edgarfgp
Copy link
Copy Markdown
Contributor Author

edgarfgp commented Apr 23, 2025

To avoid conflicts #18482 should be merged first.

T-Gro
T-Gro reviewed Apr 24, 2025
View reviewed changes
Comment thread src/Compiler/Checking/Expressions/CheckComputationExpressions.fs Outdated
T-Gro
T-Gro reviewed Apr 24, 2025
View reviewed changes
Comment thread src/Compiler/FSComp.txt Outdated
@T-Gro T-Gro enabled auto-merge (squash) April 25, 2025 08:29
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Apr 25, 2025
@edgarfgp
Merge branch 'main' into fix-16343
edb0e1a 
# Conflicts:
#	src/Compiler/Checking/Expressions/CheckComputationExpressions.fs
auto-merge was automatically disabled April 25, 2025 12:07

Head branch was pushed to by a user without write access

@edgarfgp
Copy link
Copy Markdown
Contributor Author

edgarfgp commented Apr 25, 2025

Fixed the merged conflict and this is green again :)

@edgarfgp edgarfgp mentioned this pull request Apr 26, 2025
Merged
2 tasks
@T-Gro T-Gro merged commit 9995898 into dotnet:main Apr 28, 2025
33 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Apr 28, 2025
This was referenced Jun 16, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow _ in async use! _ pattern (lift FS1228 restriction)

3 participants

@edgarfgp @abonie @T-Gro