Skip to content

Fix #977 - CompiledName on a member whose declaring type is in a namespace #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinRansom merged 1 commit into from
Dec 6, 2016
Merged

Fix #977 - CompiledName on a member whose declaring type is in a namespace #1837

KevinRansom merged 1 commit into from
Dec 6, 2016

Conversation

@forki
Copy link
Contributor

@forki forki commented Nov 25, 2016 •
edited
Loading

Basically I removed the || condition and now we can write:

namespace Test

type T() =
    [<CompiledName "A">]
    member this.a() = ()

@forki forki mentioned this pull request Nov 25, 2016
Closed
@forki forki closed this Nov 25, 2016
@forki forki reopened this Nov 25, 2016
@forki
Copy link
Contributor Author

forki commented Nov 25, 2016

ready for review

@dsyme dsyme changed the title Try to fix #977 Fix #977 Nov 26, 2016
@dsyme dsyme changed the title Fix #977 Fix #977 - CompiledName on a member whose declaring type is in a namespace Nov 26, 2016
@KevinRansom KevinRansom merged commit 1099a5e into dotnet:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme dsyme approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@forki @dsyme @KevinRansom @msftclas