Skip to content

Conversation

@vasily-kirichenko
Copy link
Contributor

Fix #1785, thanks @vladima

Copy link
Contributor

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💋

open Microsoft.CodeAnalysis.Editor.Implementation.CommentSelection
open Microsoft.CodeAnalysis.Host.Mef
open Microsoft.CodeAnalysis
open System.Composition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all these namespaces needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea. errors are not highlighted in vs 2015 on this project. Ionide highlight almost everything as errors...

@dsyme
Copy link
Contributor

dsyme commented Nov 24, 2016

Awesome @vasily-kirichenko @vladima. Will merge when green

@dsyme dsyme merged commit 8e0e0da into dotnet:master Nov 24, 2016
@dsyme
Copy link
Contributor

dsyme commented Nov 24, 2016

Thank you @vasily-kirichenko and @vladima. I can't wait until we merge all the VFPT features too :)

@vasily-kirichenko
Copy link
Contributor Author

@dsyme I think coloring and "highlight current symbol in file" could be ported from VFPT quite easily. Re-implementing coloring could be a waste of time, there are many corner cases and we have a lot at tests for it.

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants