Fix type providers on VS2017 RC #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
And fixed! At least for FSharp.Data in a script
FSharp.Data and the type provider starter pack uses a bunch of odd things to get some things to work, I'll put them under test to make sure we don't break them in the future. |
Contributor
Author
|
And fixed for the case reported in the bug:
|
Contributor
Author
|
This is ready to go in apart from needing some extra testing to pin down this in the future |
Contributor
|
Awesome |
Contributor
Author
|
Since this fixes the problems I'm going to merge this. Some testing is included in the PR. There is one more test I want to add, I'll do that separately tomorrow. |
dsyme
changed the title
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Fix type providers on VS2017 RC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to fix #1758 where type providers are broken in Visual Studio 2017
I'm testing with FSharp.Data current release. Currently working through a number of issues