Skip to content

Minor Build Configuration Improvements #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinRansom merged 4 commits into from
Nov 17, 2016
Merged

Minor Build Configuration Improvements #1760

KevinRansom merged 4 commits into from
Nov 17, 2016

Conversation

@cloudRoutine
Copy link
Contributor

@cloudRoutine cloudRoutine commented Nov 17, 2016 •
edited
Loading

gitignore 'tests/fsharpqa/testenv/bin/'

after each build git picks up the detritus

this fixes that

@cloudRoutine
Copy link
Contributor Author

cloudRoutine commented Nov 17, 2016

Anyone who has preview3 or preivew4 of the dotnet cli installed on their machine can run into issues when they try to build the coreclr version of fsc, or just use the cli within the repo. global.json locks the SDK version to prevent those issues.

@cloudRoutine cloudRoutine mentioned this pull request Nov 17, 2016
Closed
@cloudRoutine cloudRoutine changed the title gitignore 'tests/fsharpqa/testenv/bin/' Minor Build Configuration Improvements Nov 17, 2016
KevinRansom
KevinRansom reviewed Nov 17, 2016
View reviewed changes
global.json Outdated
@@ -0,0 +1,6 @@
{
Copy link
Contributor

@KevinRansom KevinRansom Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the issues. The repo should only use the cli found in tools\dotnet/cli. If we are not including the path to that when we need to then there is a bug.

So please remove this file. the rest looks great.

Copy link
Contributor Author

@cloudRoutine cloudRoutine Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue arises is when you want to use dotnet <command> in the terminal, like if you want to build, restore, or run only one particular project

Copy link
Contributor Author

@cloudRoutine cloudRoutine Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the hack to make dotnet behave is simple enough too

KevinRansom
KevinRansom suggested changes Nov 17, 2016
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the global.json

thanks

@mmitche
Copy link
Member

mmitche commented Nov 17, 2016

@dotnet-bot test this please (testing CI move to other server)

@KevinRansom
Copy link
Contributor

KevinRansom commented Nov 17, 2016

Thanks @cloudRoutine

Kevin

@KevinRansom KevinRansom merged commit 9bcfe0b into dotnet:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KevinRansom KevinRansom KevinRansom requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cloudRoutine @mmitche @KevinRansom @msftclas