Additional testing for CoreCLR and make it easier to play with F# Compiler and Interactive on CoreCLR #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
Contributor
Author
|
@KevinRansom I did some more work on this
I think it's ready to go through once we're green |
dsyme
changed the title
Member
|
@dotnet-bot test this please (test ci move) |
Contributor
Author
|
@mmitche Could you explain what the "test this please" thing is? Do we need to do it or are you testing something? Just curious. Also should we update the badges on README.md? |
Member
|
@dsyme it restarts all the tests on the PR. I moved you to the other CI server and wanted them to kick off again there. It looks pretty decent so far, so I'll probably update the badges in a bit. |
Contributor
Author
|
@dotnet-bot test this please (heisen failure in StructLayout test, seems unrelated) |
Contributor
|
@dsyme can you use Squash and Merge when accepting PR's pls. |
Contributor
Author
|
@KevinRansom Sorry my bad - I meant to |
Contributor
|
@dsyme ... lol. It's not a problem ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time looking into FSI.EXE on CoreCLR
After this PR you can run
These are shims for CoreCLR fsc.exe and fsi.exe respectively
fsiis the .NET Framework fsi used to run the shimCompileProj.fsxand replaces it.This also makes more improvements to the
fsharpsuite.