Use vssdk from nuget #1748
Merged
Use vssdk from nuget #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@OmarTawfik @brettfo could you take a look pls. Kevin |
OmarTawfik
approved these changes
Nov 16, 2016
Contributor
There was a problem hiding this comment.
@KevinRansom I don't get why using AddVsSdkAttributesToSomeCoreComponents. Why not just including the targets files?
brettfo
approved these changes
Nov 16, 2016
|
|
||
| echo ---------------- Done with arguments, starting preparation ----------------- | ||
| if '%VSSDKInstall%'=='' ( | ||
| set VSSDKInstall=%~dp0packages\Microsoft.VSSDK.BuildTools.15.0.25907-RC2\tools\vssdk |
Member
There was a problem hiding this comment.
Nit: put this version number in another variable.
| <UseSourceLink>true</UseSourceLink> | ||
| <UseGatherBinaries>true</UseGatherBinaries> | ||
| <AddVsSdkAttributesToSomeCoreComponents>true</AddVsSdkAttributesToSomeCoreComponents> | ||
| <VsSDKInstall>$(MSBuildThisFileDirectory)..\packages\Microsoft.VSSDK.BuildTools.15.0.25907-RC2\tools\vssdk</VsSDKInstall> |
Member
There was a problem hiding this comment.
Same nit about capturing version numbers in a variable.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Use vssdk from nuget * forget to commit packages.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the VSSDKfrom an installed VS. This PR use the RC VSSDK from nuget.