Skip to content

Conversation

@KevinRansom
Copy link
Contributor

  1. Build fsharp.core.dll to nuget package.
  2. use built nuget package for fsharp.core in fsharp.core.unittests coreclr build
  3. Get tuplesample.dll from nuget rather than local
  4. remove a couple of unnecessary nuget.config files

@KevinRansom
Copy link
Contributor Author

@dotnet-bot test this please

@forki
Copy link
Contributor

forki commented Nov 12, 2016

Publish + unittests? Where are the unittests published to? And why?

Am 12.11.2016 09:50 schrieb "Kevin Ransom (msft)" <[email protected]

:

@dotnet-bot https://github.com/dotnet-bot test this please


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1733 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNGfZN9t8DWood3r_1tyUt4ng7tmCks5q9X3ygaJpZM4KwVxZ
.

@KevinRansom
Copy link
Contributor Author

It uses dotnet publish to move the tests and required dependencies to testbin so that they can run. Previously it was done using hacky file copies.

Kevin

@forki
Copy link
Contributor

forki commented Nov 12, 2016

Ah Ok. I thought this was dotnet build is already doing. Thx

Am 12.11.2016 10:01 schrieb "Kevin Ransom (msft)" <[email protected]

:

It uses dotnet publish to move the tests and required dependencies to
testbin so that they can run. Previously it was done using hacky file
copies.

Kevin


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1733 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNBW4EOfz7ddk8SmmjhmEKQ7-fy-Sks5q9YBygaJpZM4KwVxZ
.

@KevinRansom KevinRansom merged commit d0a1356 into dotnet:master Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants