Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 11, 2016

This is a cleanup of the "fsharp" suite, to make it simpler

Still to be finalized, submitting for more complete CI

</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)'=='net40'">
<DefineConstants>$(DefineConstants);FX_ATLEAST_45</DefineConstants>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not at least_45, since it is supposed to run on dotnet40

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

win 7 is 40.

<TargetType>LIBRARY</TargetType>
<UseVsVersion>true</UseVsVersion>
<NoWarn>$(NoWarn);3001,3002,3003</NoWarn>
<DefineConstants>$(DefineConstants);UITHREAD_FOR_LANGUAGESERVICE</DefineConstants>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these projects are all going to go away next week, once OMAR cleans up after the roslyn changes work.

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this is necessary right now. Changed my mind. It's fine.

@mmitche
Copy link
Member

mmitche commented Nov 11, 2016

@dotnet-bot test this please (changed hooks)

@dsyme
Copy link
Contributor Author

dsyme commented Nov 12, 2016

@KevinRansom A heads up that the changes delete the batch files for the "fsharp" suite (hence the 9000 line removal)

I'm working out how to compile the "fsharp" suite driver code for .NET Core, When run in that mode, can invoke the .NET Core F# compiler to run most of the tests (same coverage as the FSC_CORE permutation).

I'm trying to reduce the use of permutations and make things a bit more explicit.

Also am trying to allow those tests to be run from the F# REPL in scripting mode, something which has worked well for F# Compiler Service testing.

@dsyme
Copy link
Contributor Author

dsyme commented Nov 12, 2016

Also addresses #889

@dsyme dsyme closed this Nov 13, 2016
@dsyme dsyme reopened this Nov 13, 2016
@dsyme dsyme merged commit 6ce962e into dotnet:master Nov 14, 2016
@dsyme dsyme mentioned this pull request Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants