-
Notifications
You must be signed in to change notification settings - Fork 842
[WIP] test cleanup #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] test cleanup #1732
Conversation
src/FSharpSource.targets
Outdated
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(TargetFramework)'=='net40'"> | ||
| <DefineConstants>$(DefineConstants);FX_ATLEAST_45</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not at least_45, since it is supposed to run on dotnet40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
win 7 is 40.
| <TargetType>LIBRARY</TargetType> | ||
| <UseVsVersion>true</UseVsVersion> | ||
| <NoWarn>$(NoWarn);3001,3002,3003</NoWarn> | ||
| <DefineConstants>$(DefineConstants);UITHREAD_FOR_LANGUAGESERVICE</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these projects are all going to go away next week, once OMAR cleans up after the roslyn changes work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think this is necessary right now. Changed my mind. It's fine.
|
@dotnet-bot test this please (changed hooks) |
|
@KevinRansom A heads up that the changes delete the batch files for the "fsharp" suite (hence the 9000 line removal) I'm working out how to compile the "fsharp" suite driver code for .NET Core, When run in that mode, can invoke the .NET Core F# compiler to run most of the tests (same coverage as the FSC_CORE permutation). I'm trying to reduce the use of permutations and make things a bit more explicit. Also am trying to allow those tests to be run from the F# REPL in scripting mode, something which has worked well for F# Compiler Service testing. |
|
Also addresses #889 |
This is a cleanup of the "fsharp" suite, to make it simpler
Still to be finalized, submitting for more complete CI