test fixes #1729
Merged
test fixes #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
commented
Nov 10, 2016
build.cmd
Outdated
| set command="%_dotnetexe%" "%~dp0tests\testbin\!BUILD_CONFIG!\coreclr\fsharp.core.unittests\FSharp.Core.Unittests.dll" | ||
| if '%TEST_CORECLR_COREUNIT_SUITE%' == '1' ( | ||
| REM these copies should not be needed, see https://github.com/fsharp/fsharp/issues/642 | ||
| xcopy /S /Q /Y src\fsharp\FSharp.Core.Unittests\bin\!BUILD_CONFIG!\netcoreapp1.0\* "%~dp0tests\testbin\!BUILD_CONFIG!\coreclr\fsharp.core.unittests\" |
Contributor
Author
|
Thanks to @enricosada for helping to work out how to use FsCheck. See fsharp/fsharp#642 which was causing problems |
Contributor
Author
|
@KevinRansom When I merged this I thought that the "part 2" .NET Core tests were passing. Instead the changes means that the pre-existing "missing DLL" failure is now being recorded as an actual failure. |
Contributor
|
I'm actually working on nugetising this. |
Contributor
Author
|
@KevinRansom great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1728 and makes sure we are checking the error code.
This PR also removes the
excludeoption from build.cmd which was causing batch file hell (because of the use of a!character!), which was only used to exclude Expensive tests. Now use an explicitinclude Expensive.