fix build of "net40" when VS is not installed #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I haven't got a machine without VS to check this. Will ask @colinbull to check on. We should really CI the build when Visual Studio is not installed. Let's look into that separately. |
Contributor
Author
|
See #1724 for the PR to add a build of 'net40' without VS to jenkins |
dsyme
commented
Nov 8, 2016
| <!-- That DLL is logically part of the F# Compiler and F# Interactive but is shipped as part of the Visual F# IDE Tools --> | ||
| <package id="Microsoft.VisualStudio.Threading" version="14.1.131" targetFramework="net46" /> | ||
| <package id="Microsoft.VisualStudio.Shell.14.0" version="14.3.25407" targetFramework="net46" /> | ||
| <package id="Microsoft.VisualStudio.Shell.Immutable.10.0" version="10.0.30319" targetFramework="net46" /> |
Contributor
Author
There was a problem hiding this comment.
@KevinRansom Is this package ok to use for the component?
Contributor
|
@dsyme Just tested this now and Yep, happy days.. This looks like it fixes the issue. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was broken if VS was not installed because we were assuming an install of VisuaStudio to find
Microsoft.VisualStudio.Shell.Immutable.10.0