Upgrade FsCheck to 2.6.2. #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in FsCheck, tests run with a greater effective size (i.e. generated lists, arrays, strings etc are significantly longer). To make the tests complete in reasonable time the following changes were made. First, the maximum size of the test runs in the CollectionModulesConsistency and AsyncModule tests was changed to 25 and 20 resp. (down from the default, 50). Second, the `haveSameElements` function was optimized so it is no longer quadratic. (Also note this function contained a typo bug: `&& ys |>`, not xs.)
|
Hi @kurtschelfthout, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@kurtschelfthout, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Contributor
|
Thanks Kurt! |
Contributor
Author
|
The failure in AppVeyor, is not an FsCheck test. Not sure what to do about it.
|
Contributor
|
thanks for this. Excellent work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #1691.
Due to a change in FsCheck since the previously used version 2.0.3, tests run with a greater effective size (i.e. generated lists, arrays, strings etc are significantly longer). To make the tests complete in reasonable time the following changes were made.
First, the maximum size of the test runs in the
CollectionModulesConsistencyandAsyncModuletests was changed to 25 and 20 resp. (down from the default, 50).Second, the
haveSameElementsfunction was optimised so it is no longer quadratic. Also note this function contained a bug:... && ys |> ..., notxs.