Publish lkg as platform app dependent on Tools dotnetcli #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
suggested changes
Nov 4, 2016
|
|
||
| pushd .\lkg & %_dotnetexe% publish project.json -o %~dp0\Tools\lkg -r win7-x64 &popd | ||
| @if ERRORLEVEL 1 echo Error: dotnet publish failed && goto :failure | ||
| echo on |
Member
There was a problem hiding this comment.
Why is echo turned on here? The console output of the following commands will still be visible, just not what they were invoked with.
Otherwise, indention.
| pushd .\lkg & %_dotnetexe% publish project.json -o %~dp0\Tools\lkg -r win7-x64 &popd | ||
| @if ERRORLEVEL 1 echo Error: dotnet publish failed && goto :failure | ||
| echo on | ||
| pushd .\lkg\fsc & %_dotnetexe% restore & popd & if ERRORLEVEL 1 echo Error:%errorlevel% dotnet restore failed & goto :failure |
Member
There was a problem hiding this comment.
This error will never trigger because ERRORLEVEL will have been set to 0 by popd which should always succeed. Each of these lines should be split out into:
pushd .\lkg\fsc
%_dotnetexe% restore
if ERRORLEVEL 1 (
echo Error:%errorlevel% dotnet restore failed
goto failure
)
popd
Contributor
Author
There was a problem hiding this comment.
@brettfo
Yeah, I'm pretty sure that I thought that too. It turns out that popd doesn't alter the errorvalue.
A test script
pushd c:\temp
cd
c:\kevinransom\visualfsharp\tools\dotnetcli\dotnet restore project.json
popd
if ERRORLEVEL 1 echo Error: dotnet publish failed && goto :failure
cd
yields this result
c:\kevinransom\visualfsharp>pushd c:\temp
c:\temp>cd
c:\temp
c:\temp>c:\kevinransom\visualfsharp\tools\dotnetcli\dotnet restore project.json
error: project.json
c:\temp>popd
c:\kevinransom\visualfsharp>if ERRORLEVEL 1 echo Error: dotnet publish failed && goto :failure
Error: dotnet publish failed
The system cannot find the batch label specified - failure
c:\kevinransom\visualfsharp>
Member
There was a problem hiding this comment.
Huh, learn something new every day.
brettfo
approved these changes
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deploys FSC and FSI as dotnet app with a shared platform.