Skip to content

Fix typeforward resolutions #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinRansom merged 1 commit into from
Nov 3, 2016
Merged

Fix typeforward resolutions #1693

KevinRansom merged 1 commit into from
Nov 3, 2016

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Nov 2, 2016

Numerics Type Forwards were being set with the version number of the fsharp.core dll. 4.1.0.0

This ensures that they are set to the version number of the referenced system.numerics or system.runtime.numerics dll depending on whether it's full framework or portable/coreclr build.

@KevinRansom
Copy link
Contributor Author

KevinRansom commented Nov 3, 2016

This failure is addressed by: #1694

1) Ignored : FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Reflection.FSharpTypeTests.IsModule
Failing in coreclr

2) Ignored : FSharp.Core.Unittests.Portable.SurfaceArea.SurfaceAreaTest.VerifyArea
Failing in coreclr

Errors and Failures

1) Error : FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.CSharpInteropTupleArguments
System.IO.FileLoadException : Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.CSharpInteropTupleArguments()

2) Error : FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.CSharpInteropTupleReturns
System.IO.FileLoadException : Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.CSharpInteropTupleReturns()

3) Error : FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.ValueTupleDirect
System.IO.FileLoadException : Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at FSharp.Core.Unittests.FSharpStructTuples.StructTuplesCSharpInterop.ValueTupleDirect()

Run Settings
    Internal Trace: Off

Test Run Summary
  Overall result: Failed
  Test Count: 5313, Passed: 5308, Failed: 3, Inconclusive: 0, Skipped: 2
    Failed Tests - Failures: 0, Errors: 3, Invalid: 0
    Skipped Tests - Ignored: 2, Explicit: 0, Other: 0
  Start time: 2016-11-03 01:03:51Z
    End time: 2016-11-03 01:07:17Z
    Duration: 205.824 seconds

@KevinRansom KevinRansom merged commit e9b724f into master Nov 3, 2016
@KevinRansom KevinRansom deleted the references branch November 3, 2016 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KevinRansom @msftclas