Skip to content

Conversation

@KevinRansom
Copy link
Contributor

The inbox templates used an incorrect mechanism to locate fsharp.core.dll.

The inbox templates used an early version of System.ValueTuple that did not support Portable 47 profile.

Both of these issues are fixed in this PR.

Kevin

<Reference Include="System.Reflection.Metadata"><HintPath>..\..\..\packages\System.Reflection.Metadata.1.4.1-beta-24227-04\lib\portable-net45+win8\System.Reflection.Metadata.dll</HintPath></Reference>
<Reference Include="System.Collections.Immutable"><HintPath>..\..\..\packages\System.Collections.Immutable.1.2.0\lib\portable-net45+win8+wp8+wpa81\System.Collections.Immutable.dll</HintPath></Reference>
<Reference Include="System.ValueTuple"><HintPath>..\..\..\packages\System.ValueTuple.4.0.0-rc3-24212-01\lib\netstandard1.1\System.ValueTuple.dll</HintPath></Reference>
<Reference Include="System.ValueTuple"><HintPath>..\..\..\packages\System.ValueTuple.4.4.0-beta-24631-01\lib\netstandard10\System.ValueTuple.dll</HintPath></Reference>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netstandard1.0 instead of netstandard10

@brettfo
Copy link
Member

brettfo commented Oct 31, 2016

Looks good pending one comment.

:shipit:

@KevinRansom
Copy link
Contributor Author

@dotnet-bot please test this

@KevinRansom
Copy link
Contributor Author

@dotnet-bot test this please

@KevinRansom KevinRansom merged commit 0e60f38 into master Nov 1, 2016
@KevinRansom KevinRansom deleted the valutuple branch November 3, 2016 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants