Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Oct 29, 2016

This will enable newer installs of VS to prompt you to install the F# tools when attempting to open a .fsproj.

@KevinRansom @OmarTawfik

Fixes internal bug 271787.

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ... that's all you need to get project detection and auto install ... that is pretty groovy.

@cartermp
Copy link
Contributor

cartermp commented Oct 29, 2016

Interesting. I get expected behavior when opening some F# project on preview 5 today already, but hadn't tested attempting to open a project authored in VS "15".

@KevinRansom KevinRansom merged commit 44ec493 into dotnet:master Oct 29, 2016
@forki
Copy link
Contributor

forki commented Oct 29, 2016

What about fsx files outside of projects like we have in many scenarios (especially FAKE). Is this addressed as well?

@cartermp
Copy link
Contributor

@forki Not sure if it's possible to have breadcrumbs (that's the name) for specific files - thus far it's just been project-level classification. I'd like file-level classification too - I'll ask some folks.

Just to clarify, the scenario is this:

Someone opens an F# script file in Visual Studio, and they do not have F# tools installed. Opening that script file in VS prompts them to install the F# tools.

@0x53A
Copy link
Contributor

0x53A commented Oct 29, 2016

re breadcrumbs for fsx: I think it would be worth it to include something like this (#1040 (comment)) also for fsx files.

@forki
Copy link
Contributor

forki commented Oct 29, 2016

@cartermp yes exactly. We had this feature request since ms removed F# from default installation.

@forki
Copy link
Contributor

forki commented Oct 30, 2016

@cartermp and thanks for taking care of this. It always was a super important use case for many C# users that used F# only for FAKE.

Side note: "Fixes internal bug 271787" - sad to still see such things here. (yeah I know why).

@brettfo brettfo deleted the project-classifier branch January 9, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants